-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for column layout #708
Comments
Of course it would be great and handy, there is no doubt about that but most of the time it complicates editing experience because we want more and more nesting. But I am thinking a different and endless approach right now. How? For example, those columns can be a single module that takes the number of columns as parameters and each column could has one configure button to open a modal which has another full editor.js instance and other configuration inputs. We could add columns in that modal's editor too and that columns could open another modals and so on. This way, our editing experience never stuck and we could do crazy nestings. |
I developed editor-js-grid, but EditorJS can't be nested. https://www.npmjs.com/package/editor-js-grid I'm fixing EditorJS to be nested. |
It looks like you've worked hard. I respect that. I wonder do you think that a solution like I explained above cannot be produced? |
https://codesandbox.io/s/editor-js-grid-nest-ro2uz?fontsize=14&hidenavigation=1&theme=dark My demo launches Editor.js instance each grid item. |
Do you have a valid link for your module? It would be great to see how you solved your problem. Both the links you provide are 404 now. |
@hayatbiralem @netpalantir But, I'm developing an alternative plugin: editorjs-inline. |
editor-js-grid is revived as editorjs-layout! |
Hey, I have been working on a proof of concept that involves nesting editor.js No code online yet, but if people are interested I can publish EditorJsColumnsPlugin.mp4Note : |
@calumk That looks pretty much like an ideal solution. We are very interested in using it if you publish it in the near future :) |
@BLumbye Working on releasing this, but its probably realistically a week away, as I'm swamped with other work at the moment |
@calumk This is exactly what I need and I look forward to seeing you release it soon. |
A very buggy first release is here.
|
@calumk Thanks, I got it. |
@calumk This is just what I was looking for. Thank you so much for publishing this. Also, code is super clean so thanks for that :). I looked at the code and it seems like this generates new editor instance for each column. Do you have any opinion on what's the upper limit of # of instances before performance issues start to creep in. If I have 3 X 3 grid, that's 9 instances. If I then add 2 columns, that's 2 more so 11 instances in total. Might be too much for system to handle? |
Hey, There are a few issues with the current implementation Very happy to accept pull requests etc |
It would be great if blocks could be arranged in columns. Here is an example from Notion, where dragging a block to the left or right edge of another block positions them in a column layout.
While dragging:
The result:
The text was updated successfully, but these errors were encountered: