Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create binary before sending it to webpack loader #5115

Merged
merged 2 commits into from
Nov 12, 2020

Conversation

CompuIves
Copy link
Member

This will make binary loaders from webpack (like arraybuffer-loader) work.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c768c90:

Sandbox Source
Notifications Test Configuration

@lbogdan
Copy link
Contributor

lbogdan commented Nov 12, 2020

Build for latest commit c768c90 is at https://pr5115.build.csb.dev/s/new.

@drcmda
Copy link

drcmda commented Nov 12, 2020

Tested it with something that expects a real arraybuffer and it worked! 👍

@CompuIves CompuIves merged commit e7dca4f into master Nov 12, 2020
@CompuIves CompuIves deleted the fix/binary-webpack-loader branch November 12, 2020 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants