Fix typescript error

[yeion7]

What kind of change does this PR introduce?

Closes #2822
Closes #2836
Closes #2911

What is the current behavior?

What is the new behavior?

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

1. Create a React TS sandbox
2. Fork sandbox
3. Save file or add new dependency

Checklist

• Documentation
• Testing
• Ready to be merged
  
• Added myself to contributors table
  

[yeion7]

@christianalfoni 🙏🏻

[lbogdan]

Build for latest commit e21dc1d is at https://pr2913.build.csb.dev/s/new.

[TrevorSayre]

@lbogdan considering the context of the PR, perhaps this link instead: https://pr2913.build.csb.dev/s/react-ts

This resolves #2822 for me.

[CompuIves]

Wow this is interesting, we decided to only do modulePaths as an optimization (so we don't have to send new files for every code change, as the workers only care about saved code), but it seems like we did something wrong there. Really good find @yeion7! Now I'm curious what caused this bug in the first place, I wonder what we're actually sending to the workers after adding a dependency...

[CompuIves]

Hmm, after the fork modulesByPath is very different...

Oh yep, it seems like it is modulePaths at that point...

[CompuIves]

This could also be the cause of the sudden empty editor state (@christianalfoni). Let's merge this in now for a quick fix, and take a closer look whether we can optimize this. We prefer not to send all files on a single keypress, so this is not really sustainable.

[CompuIves]

This is an incredible find @yeion7, this is super impressive! Thanks for digging in!

[yeion7]

Thanks!

@CompuIves there are some documentation about how this (workers communication) works at CodeSandbox?

[TrevorSayre]

Just to confirm, is this not yet live? What is the best way to track when a PR is released into the wild?

[lbogdan]

Just to confirm, is this not yet live?

@TrevorSayre We just deployed it.

What is the best way to track when a PR is released into the wild?

We're currently working on making production always reflect master.