Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 Refactored 🧠 Overmind Hacktober | /app/pages/Sandbox/Editor/Workspace/Files/DirectoryEntry/index.js #2787

Merged

Conversation

malwilley
Copy link
Contributor

What kind of change does this PR introduce?

Refactor /app/pages/Sandbox/Editor/Workspace/Files/DirectoryEntry/index.js to use TS/hooks.

@Saeris @christianalfoni

What is the current behavior?

#2621

What steps did you take to test this? This is required before we can merge.

  1. Checked sandbox file directory locally.
  2. Ran yarn lint && yarn typecheck

Checklist

  • Documentation N/A
  • Testing
  • Ready to be merged
  • Added myself to contributors table

@vercel vercel bot temporarily deployed to staging October 15, 2019 05:09 Inactive
@vercel
Copy link

vercel bot commented Oct 15, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/codesandbox/codesandbox-client/bm5tajk2e
🌍 Preview: https://codesandbox-cl-git-fork-malwilley-2621-refactor-director-c254e8.codesandbox1.now.sh

@christianalfoni
Copy link
Contributor

christianalfoni commented Oct 15, 2019

Hi there!

Great stuff, though there was a tiny bug there. Have added a PR to your branch which you have to merge in :)

malwilley#1

@christianalfoni
Copy link
Contributor

The following has been tested:

  • Create files
  • Create directories
  • Automatic fork by creating directory
  • Delete files
  • Delete directory
  • Move file
  • Validation indication
  • Upload files

@Saeris Saeris added Hacktoberfest 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Oct 15, 2019
@CompuIves CompuIves merged commit b0934bc into codesandbox:master Oct 17, 2019
@malwilley
Copy link
Contributor Author

@christianalfoni I'm very sorry I somehow missed your comments before this was merged! Thanks for looking at this and finding that bug. Do you want to make a PR to master for that fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants