Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 Refactored 🧠 Overmind Hacktober | /app/pages/Profile/index.js #2729

Merged
merged 1 commit into from
Oct 17, 2019

Conversation

malwilley
Copy link
Contributor

What kind of change does this PR introduce?

Refactor /app/pages/Profile/index.js to use TS/hooks/Overmind.

Added typings for react-helmet and react-router-dom, which necessitated changes in some other files.

@Saeris @christianalfoni

What is the current behavior?

#2621

What steps did you take to test this? This is required before we can merge.

  1. Checked profile page locally.
  2. Ran yarn lint && yarn typecheck

Checklist

  • Documentation N/A
  • Testing
  • Ready to be merged
  • Added myself to contributors table

@vercel vercel bot temporarily deployed to staging October 11, 2019 02:45 Inactive
@vercel
Copy link

vercel bot commented Oct 11, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/codesandbox/codesandbox-client/idfdv33c3
🌍 Preview: https://codesandbox-client-git-fork-malwilley-2621-refactor-profile.codesandbox1.now.sh

@Saeris Saeris added Hacktoberfest 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Oct 13, 2019
Copy link
Member

@CompuIves CompuIves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks a lot for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants