Prevent crash on team items #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://codesandbox-client-git-fork-yeion7-fix-teams-crash.codesandbox1.now.sh |
|
@CompuIves could check this PR? there are a few crash reports that are resolved with this PR |
|
Sorry, I just reviewed a similar PR: #2499. And requested comment by @CompuIves as well :) Should merge this one as you were first, heh ;) |
SaraVieira
approved these changes
Sep 25, 2019
This was referenced Sep 25, 2019
|
Hey Sorry @yeion7 @christianalfoni I didn't see this PR as this was not referencing to the issues that I checked. Will check existing PRs before creating a new one :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix
What is the current behavior?
#2482
#2496
#2487
#2484
#2497
#2495
#2505
What is the new behavior?
We check if
menode exists and also use an empty array as default teamsWhat steps did you take to test this?
Checklist