Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gitattributes #203

Merged
merged 2 commits into from
Sep 19, 2017
Merged

Add .gitattributes #203

merged 2 commits into from
Sep 19, 2017

Conversation

tansongyang
Copy link
Contributor

This makes it easier for Windows users to contribute. Previously, Windows users could not run yarn test because linting would fail. Linting failed because eslint is currently configured to only accept Unix line endings.

The first line enforces defaults. The second line forces js files to keep Unix line endings on checkout, even in Windows. This allows linting to succeed.

See eslint's linebreak-style docs.

@CompuIves
Copy link
Member

Ahh nice @tansongyang! Merging now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants