Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage - Fix frameworks text / icons overflowing at mobile rez #1746

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Homepage - Fix frameworks text / icons overflowing at mobile rez #1746

merged 1 commit into from
Apr 10, 2019

Conversation

JonShort
Copy link
Contributor

@JonShort JonShort commented Apr 8, 2019

What kind of change does this PR introduce?
Bug fix - cosmetic

What is the current behavior?
Currently the text & icons in the 'Tailored for web applications' section flow off the screen at mobile resolution.

Bug report - #1745

Screenshot 2019-04-08 at 22 02 39

What is the new behavior?

  • Text no longer flows off the screen
  • Framework icons can be scrolled horizontally by the user
  • Homepage appears as before at desktop resolution

Screenshot 2019-04-08 at 22 02 50

Checklist:

  • Documentation - N/A
  • Tests - N/A
  • Ready to be merged
  • Added myself to contributors table - N/A

Scrolling behaviour could be removed and replaced with wrapping icons; but this could affect the UX of clicking a framework icon and viewing the information underneath.

- Allow framework icons to be scrolled by user
- Fix frameworks title / description from flowing off the screen
horizontally
@CompuIves
Copy link
Member

Ohh thank you so much for fixing this! Greatly appreciated!

@allcontributors[bot] please add @JonShort for code

@allcontributors
Copy link
Contributor

@CompuIves

I've put up a pull request to add @JonShort! 🎉

@CompuIves CompuIves merged commit 98602a6 into codesandbox:master Apr 10, 2019
@JonShort JonShort deleted the hp-mobile-overflow branch April 10, 2019 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants