Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed throws errors to console when editing or switching views #226

Closed
malwilley opened this issue Oct 10, 2017 · 2 comments
Closed

Embed throws errors to console when editing or switching views #226

malwilley opened this issue Oct 10, 2017 · 2 comments
Labels

Comments

@malwilley
Copy link
Contributor

This can be seen on the homepage or any direct link to an embed, this one for example. While editing or switching views, it throws errors to the console:

image

I poked around a bit and found that the CodeEditor component isn't being called with all the necessary props. Adding corrections={[]} seems to be enough to fix it (I assume corrections is not used for embed?). It is also missing a couple other required props but those don't result in any bugs. Running the flow typechecker gives nearly 900 errors 😬

Would you accept a PR to fix this issue? And perhaps some other typing errors?

@CompuIves
Copy link
Member

CompuIves commented Oct 10, 2017

Thanks for reporting this! Your suggested solution is good, would be really great if you could open a PR for it. Man, I'm really ashamed with how Flow is handled right now, it's a mess...

@lbogdan
Copy link
Contributor

lbogdan commented Oct 10, 2017

Maybe we should do a "fix flow" hackathon, as we did with "fix eslint"! (I have to admit I got a bit discouraged after fixing hundreds of eslint errors 😄)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants