-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed throws errors to console when editing or switching views #226
Labels
Comments
Thanks for reporting this! Your suggested solution is good, would be really great if you could open a PR for it. Man, I'm really ashamed with how Flow is handled right now, it's a mess... |
Maybe we should do a "fix flow" hackathon, as we did with "fix eslint"! (I have to admit I got a bit discouraged after fixing hundreds of eslint errors 😄) |
malwilley
added a commit
to malwilley/codesandbox-client
that referenced
this issue
Oct 12, 2017
CompuIves
pushed a commit
that referenced
this issue
Oct 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This can be seen on the homepage or any direct link to an embed, this one for example. While editing or switching views, it throws errors to the console:
I poked around a bit and found that the CodeEditor component isn't being called with all the necessary props. Adding
corrections={[]}
seems to be enough to fix it (I assume corrections is not used for embed?). It is also missing a couple other required props but those don't result in any bugs. Running the flow typechecker gives nearly 900 errors 😬Would you accept a PR to fix this issue? And perhaps some other typing errors?
The text was updated successfully, but these errors were encountered: