Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding viper config #2

Merged
merged 6 commits into from
Feb 9, 2023
Merged

Adding viper config #2

merged 6 commits into from
Feb 9, 2023

Conversation

coderj001
Copy link
Owner

@coderj001 coderj001 commented Feb 9, 2023

Description

Type of Change

  • 馃摎 Documentation (Non-breaking change; Changes in the documentation)
  • 馃敡 Bug fix (Non-breaking change; Fixes an existing bug)
  • 馃 Improvement (Non-breaking change; Improves existing feature)
  • 馃殌 New feature (Non-breaking change; Adds functionality)
  • 馃攼 Security fix (Non-breaking change; Patches a security issue)
  • 馃挜 Breaking change (Breaks existing functionality)

Checklist

  • I've read the Code of Conduct and this pull request adheres to it.
  • I've read the CONTRIBUTING.md guide.
  • I've run the complete test-suite using make test-suite, and it passed with no errors.
  • I've written new tests for all changes introduced in this pull request (where applicable).
  • I've documented any new methods/structures/packages added.

Review Process

Reviewees:

  1. Prefer incremental and appropriately-scoped changes.
  2. Leave a comment on things you want explicit feedback on.
  3. Respond clearly to comments and questions.

Reviewers:

  1. Test functionality using the criteria above.
  2. Offer tips for efficiency, feedback on best practices, and possible alternative approaches.
  3. For shorter, "quick" PRs, use your best judgment on the previous point.
  4. Use a collaborative approach and provide resources and/or context where appropriate.
  5. Provide screenshots/grabs where appropriate to show findings during review.
  6. In case of a potential bug in PR, be sure to add steps to reproduce the issue (where applicable)

@coderj001 coderj001 merged commit 3e7be60 into master Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant