Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packed fields #1

Merged
merged 2 commits into from
Feb 26, 2013
Merged

Packed fields #1

merged 2 commits into from
Feb 26, 2013

Conversation

jwroblewski
Copy link

Added support for packed fields.

@codekitchen
Copy link
Owner

Hey sweet, thanks. The Travis build is failing because it doesn't have the compiler available when running the tests -- see how I fixed the other tests in a479dbb

Alternatively, I've been digging through the Travis documentation and it looks like I should actually be able to install protobuf/protoc before the build starts from an apt package, I just need to figure out the right magic to make it happen.

@jwroblewski
Copy link
Author

Would be nice to have protoc available on travis. Check out the below .travis.yml, it downloads and installs protoc directly from sources:

https://github.com/christiankerl/org.eclipselab.emf.ecore.protobuf/blob/master/.travis.yml

@jwroblewski
Copy link
Author

I fixed the specs, so travis is now green even w/o protoc installed. I also squashed all the commits, so the complete feature is now in a single place (eac5a7e).

@codekitchen
Copy link
Owner

Looks great, thanks for the contribution. Good link to that travis file too, I'll try to get protoc installed on travis runs soon.

codekitchen added a commit that referenced this pull request Feb 26, 2013
@codekitchen codekitchen merged commit 5fae293 into codekitchen:master Feb 26, 2013
codekitchen pushed a commit that referenced this pull request Aug 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants