Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shield:user create with default group #999

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

datamweb
Copy link
Collaborator

@datamweb datamweb commented Jan 12, 2024

Description
fix: #998

The user registration form sets the default group value for the user when a new user is registered. Although I don't consider this a bug, I prefer that this process be done for command shield:user create as well.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@datamweb datamweb added the bug Something isn't working label Jan 12, 2024
@datamweb
Copy link
Collaborator Author

Two items.
I don't know why Rector has not been updated to the latest version by Dependabot. Maybe it's because of the changes in Devkit. @samsonasik please take a look if you can.

PRLintReloaded It requires configuration, which I do not have the necessary access to do, please do the necessary configuration.

@lonnieezell
Copy link
Member

In the future I'd rather see all of the unrelated fixes in a separate PR. I know Rector was being a pain though.

While I like the idea, I think in the situations I'd be using it from the command line I'd rather be able to define which role during the creation process, instead of being forced into the default and then having to go to the database to change it.

What do you think about reading the available roles from the config file and presenting that as a required choice to the user?

@samsonasik
Copy link
Member

@datamweb it probably related with dependabot config, 0.18.x probably only call 0.18.y, while 0.19.a need to be triggerable on specific config. CodeIgniter4 repo seems auto-update it

@datamweb
Copy link
Collaborator Author

What do you think about reading the available roles from the config file and presenting that as a required choice to the user?

Good idea, I'd like to come back to these PR at another time.

@datamweb datamweb marked this pull request as draft January 16, 2024 01:38
@bgeneto
Copy link
Contributor

bgeneto commented Jan 17, 2024

What do you think about reading

One can also make the -g argument available in the create action in order to set the user group otherwise use the default if not informed. This way we simplify the code and minimize the interactions while creating a new user via cli. What do you think @lonnieezell ?

@datamweb
Copy link
Collaborator Author

PRLintReloaded It requires configuration, which I do not have the necessary access to do, please do the necessary configuration.

I send PR #1001 for add Rules.

@lonnieezell
Copy link
Member

Sorry - forgot to reply here earlier, but PRLintReloaded is installed and should be working now.

@datamweb
Copy link
Collaborator Author

In the future I'd rather see all of the unrelated fixes in a separate PR

I sent separates PRs for fix #1002 , #1003 and #1004 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: spark cli does not assign a default group to newly created user
4 participants