Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing back buttons to the Report problem screens on mobile (🅼3) #97

Open
Tracked by #76
schlos opened this issue Aug 15, 2021 · 2 comments
Open
Tracked by #76
Labels
🕷️ bug Something isn't working help wanted Extra attention is needed html/css

Comments

@schlos
Copy link
Member

schlos commented Aug 15, 2021

Describe the bug

Add missing back buttons to the Report problem flow.

Known bug, feedback from Silvija with PR 93:

Back gumb na prijavi problema ne radi pa sam ga privremeno uklonila, ne znam postoji li u base kodu verzije koju imamo jer ga nisam mogla naći

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

Screenshots

Expected: Comparison back button behaviour in 'fixmystreet' cobrand (master branch, new sw, with multistep):

Screenshot_20210815-215653_Brave.jpg

Screenshot_20210815-215730_Brave.jpg

Screenshot_20210815-215750_Brave.jpg

Comparison back button behavior in 'tlf' cobrand (v3.1, same as our develop branch) - has back button on some screens:

Screenshot_20210815-215902_Opera Touch.jpg

Back link is actually same as go back and edit problem:

Screenshot_20210815-220049_Opera Touch.jpg

Desktop (please complete the following information):

  • OS: [e.g. Windows]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

Back functionality in base cobrand:
https://gist.github.com/schlos/d1d3bd175dcee17a94ee5dd04726a716#file-fms-base-report-new-fill_in_details-html-L45

@schlos schlos changed the title popravito: Missing back buttons to the Report problem screens popravito: Missing back buttons to the Report problem screens (🅼3) Aug 16, 2021
@schlos schlos added the 🕷️ bug Something isn't working label Aug 16, 2021
@schlos schlos added this to To do in Popravi.to priorities via automation Aug 16, 2021
schlos added a commit that referenced this issue Aug 23, 2021
@schlos
Copy link
Member Author

schlos commented Aug 23, 2021

Partially fixed with the latest PR:

  • Back button is added to the final (3rd) step/screen in Report a problem flow:

photo_2021-08-23 22 51 23

  • Back button is missing in the 1st and 2nd steps:

photo_2021-08-23 22 51 28

photo_2021-08-23 22 51 30

@schlos schlos moved this from Backlog to Development to-do in Popravi.to priorities Aug 24, 2021
@schlos schlos added html/css help wanted Extra attention is needed labels Nov 11, 2021
@schlos schlos changed the title popravito: Missing back buttons to the Report problem screens (🅼3) Missing back buttons to the Report problem screens (🅼3) Nov 26, 2021
@schlos
Copy link
Member Author

schlos commented Nov 26, 2021

How to contribute?
Read our contribution guidelines at https://codeforcroatia.org/popravito-contribution-guidelines.

@schlos schlos changed the title Missing back buttons to the Report problem screens (🅼3) Missing back buttons to the Report problem screens on mobile (🅼3) Nov 26, 2021
@schlos schlos moved this from Development in progress to Backlog in Popravi.to priorities Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕷️ bug Something isn't working help wanted Extra attention is needed html/css
Projects
Development

No branches or pull requests

1 participant