Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

popravito: Unorderd lists are missing bullet symbols #134

Closed
schlos opened this issue Sep 29, 2021 · 1 comment
Closed

popravito: Unorderd lists are missing bullet symbols #134

schlos opened this issue Sep 29, 2021 · 1 comment
Assignees
Labels
🕷️ bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@schlos
Copy link
Member

schlos commented Sep 29, 2021

Describe the bug

In the /web/cobrands/popravito/base.scss we have:

ul {
    list-style-type: none;
}

Which is fine as it's used probably in the menu list items to dynamically generate menu items.

But, in the pages (FAQ, privacy policy, house rules etc), unordered lists are missing bullet symbol.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

To fix the problem, we need to add additional class to the base.css:
.with-bullets {list-style:circle}

Screenshots

Desktop (please complete the following information):

  • OS: [e.g. Windows]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

Stackoverflow:
https://stackoverflow.com/questions/26502030/adding-bullets-back-to-a-list-after-setting-list-stylenone-globally

So pages should be updated so that ul has class "with-bullet", as in the example:
<ul class="with-bullets">

@schlos schlos added 🕷️ bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Sep 29, 2021
@schlos schlos self-assigned this Sep 29, 2021
schlos added a commit that referenced this issue Sep 29, 2021
schlos added a commit that referenced this issue Sep 29, 2021
schlos added a commit that referenced this issue Sep 29, 2021
schlos added a commit that referenced this issue Sep 29, 2021
@schlos
Copy link
Member Author

schlos commented Sep 29, 2021

Fixed as per screenshot:
https://snippyly.com/img/?q=hNfQHvTv0DkDhSTMUv9n &EDIT=VZ1Od0GV5YuL1Vgp9qph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕷️ bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant