284 add contributor role #292
Conversation
…TOR role and updates the unit tests to use a contributor user.
Need to find a way to associate the user. Also adds member roles.
… before continuing. Will now update unit tests.
…the front-end refers to the concept.
| url = db.Column(db.Text) | ||
| contact_email = db.Column(db.Text) | ||
| reported_incidents = db.relationship( | ||
| 'Incident', backref='organization', lazy="select") |
There was a problem hiding this comment.
The backref here should still be source.
There was a problem hiding this comment.
If we're renaming Source to Organization on the back end for consistency with the front end, the database should also reflect that for consistency.
There was a problem hiding this comment.
Yes, but the back reference is about the relationship between the entities so it should reflect what that relationship is.
If you have users and channels the users are subscribers to the channel.
Similarly, you have users as members of an organization while the incident sees the organization as its source. Different relationships to the same entity.
There was a problem hiding this comment.
The relationship of an organization to an incident is still going to be that of a source -> Incident. The backref on org and the labelling here should stay mostly the same.
| @@ -59,10 +59,10 @@ class Incident(db.Model, CrudMixin): | |||
| """The incident table is the fact table.""" | |||
|
|
|||
| id = db.Column(db.Integer, primary_key=True, autoincrement=True) | |||
| source_id = db.Column( | |||
There was a problem hiding this comment.
These should be reverted.
| @@ -131,8 +131,8 @@ def __repr__(self): | |||
| # case_id = db.Column(db.Integer) # TODO: foreign key of some sort? | |||
|
|
|||
|
|
|||
| class SourceDetails(db.Model): | |||
| id = db.Column(db.Integer, primary_key=True) # source details id | |||
| class OrganizationDetails(db.Model): | |||
There was a problem hiding this comment.
This is still going to be SourceDetails.
|
Gonna go ahead and merge this and make the changes after. |
No description provided.