Search #206
Search #206
Conversation
ascampos
commented
Nov 2, 2021
•
ascampos
commented
frontend/pages/search/index.tsx
Outdated
| @@ -1,16 +1,17 @@ | |||
| import { useState } from "react" | |||
| import React from "react" | |||
There was a problem hiding this comment.
Next.js automatically imports React for tsx files so we can remove this line
frontend/helpers/auth.tsx
Outdated
| @@ -32,17 +32,17 @@ export function useAuth() { | |||
| */ | |||
| export function requireAuth(Component: () => JSX.Element) { | |||
There was a problem hiding this comment.
I think we can revert this file
| @@ -0,0 +1,83 @@ | |||
| import React from "react" | |||
There was a problem hiding this comment.
Next requires ever file under pages to be a routable page (that's why the frontend checks are failing), so why don't we create a compositions/search folder and move this and the css there, then update the import in search/index.
| async function onSubmit(formValues: any) { | ||
| setLoading(true) | ||
| try { | ||
| // TODO |
There was a problem hiding this comment.
Take a look at the temporary UI for how to make the API call
|
Visit the preview URL for this PR (updated for commit ascampos/police-data-trust@b4d92d8): https://police-data-trust-dev--pr206-search-p8sml42g.web.app (expires Wed, 17 Nov 2021 15:02:59 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 89ee28768ddf114979e2cf8eddd3746214cf93af |
|
@alexjball I addressed your comments, but still not sure why there's such a large diff on yarn.lock im using |
