Fixed Edit Profile #172
Merged
Fixed Edit Profile #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjball
previously approved these changes
Oct 4, 2021
| import { useAuth, requireAuth } from "../../helpers" | ||
| import styles from "./profile-type.module.css" | ||
|
|
||
| export default requireAuth(function ProfileType() { |
There was a problem hiding this comment.
The requireAuth call should wrap the whole Profile page component, so please move to pages/profile/index.tsx.
There was a problem hiding this comment.
got it, thanks
|
just need to fix conflicts then good to merge :) |
…/police-data-trust into bug166-broken-edit-profile
|
All set! Even the stories all work now! |
alexjball
previously approved these changes
Oct 5, 2021
|
YES!! |
alexjball
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #166. Turns out it was just missing a FormProvider, but went ahead and restructured all the Profile components so they resemble the rest of the project, with components only grouped together if they need to be. Also, the Profile is now getting data (at least user data) from the auth context instead of loading it independently from some JSON file. So it's still mock data, but at least it's the same mock data as everything else, and will therefore be able to switch to real data as soon as that becomes available.