Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile page #151

Merged
merged 93 commits into from
Sep 27, 2021
Merged

Profile page #151

merged 93 commits into from
Sep 27, 2021

Conversation

acharliekelly
Copy link
Collaborator

Addresses #137 (and also #138, #139, #140, and #141). Mostly works, except for:

  • CSS is all wrong
  • Code is not dry. Actually dripping wet. Suggestions appreciated.

@acharliekelly
add profile page
9b3519f
@acharliekelly
about page placeholder
908286c
@acharliekelly
profile data
c4bd56c
@acharliekelly
profile menu
324e16f
@acharliekelly
profile css
3c1defe
@acharliekelly
add '/about' and '/profile' to routes
277ae3c
@acharliekelly
lift nav comps for outside use
f80eaa2
@acharliekelly
lift nav use
e934200
@acharliekelly
move page css module
c84aec8
@acharliekelly
remove props
02765b1
@acharliekelly
move model stuff
d2f6be5
@acharliekelly
content-specific css
e73d012
@acharliekelly
profile content components
0d04535
@acharliekelly
nav specific css
b4f0997
@acharliekelly
internal navigation
bed927d
@acharliekelly
model stuff
7b35fcd
@acharliekelly
mock users
9b3b403
@acharliekelly
profile page
1f4df00
@acharliekelly
rename to index
ff65a56
@acharliekelly
form css
8dd4d72
@acharliekelly
profile info component
edbfdb9
@acharliekelly
profile type component
1246eab
@acharliekelly
all the model stuff
d78935f
@acharliekelly
page
33f6342
@acharliekelly
tweak button styles
3ff8159
@acharliekelly
button styles
8cc20dc
@acharliekelly
snapshot tests
99e1051
@acharliekelly
mock search data for saved searches
e2fcadc
@acharliekelly
look more like design
01b90e9
@acharliekelly
saved results pages (wip)
e79f96c
@acharliekelly
Copy link
Collaborator Author

Updates:

  • Improved CSS - looks more like FIGMA than before, but still needs work (also not responsive at all)
  • DRYer tables
  • moved mock data so it won't conflict with Jest mocks

alexjball
alexjball previously approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@alexjball alexjball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run npm run fix to fix the formatting and fix the broken test, but otherwise LGTM!
For the test, I think you need to wrap linkText in an <a> in profile-type.tsx. Check out the other usages of Link

alexjball
alexjball approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@alexjball alexjball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made some changes to pass CI, looks great! merging

@alexjball alexjball merged commit 7d59d6f into codeforboston:main Sep 27, 2021
This was referenced Sep 28, 2021
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexjball alexjball alexjball approved these changes

@JMStudiosJoe JMStudiosJoe JMStudiosJoe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@acharliekelly @JMStudiosJoe @alexjball