Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deploy): Remove the 3rd party action; use Heroku CLI directly #68

Merged
merged 1 commit into from
Jun 22, 2021
Merged

fix(deploy): Remove the 3rd party action; use Heroku CLI directly #68

merged 1 commit into from
Jun 22, 2021

Conversation

jcockhren
Copy link
Collaborator

This Pull Request attempts to use the Heroku CLI directly b/c it's comes preinstalled on the Ubuntu 20.04 image.

See: https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-README.md

closes #67

@JMStudiosJoe
Copy link
Collaborator

can you update the PR base branch please? Also I think we will be moving towards AWS deployments @DMalone87 were you able to confirm that?

@DMalone87
Copy link
Collaborator

Yes, correct

@jcockhren
Copy link
Collaborator Author

I may have misunderstood what you were asking me @DMalone87. I thought it the move to AWS ahead of MVP completion was due to the deploys being broken. Or are there other reasons?

You all want to abandon this PR if it fixes Heroku deploy today?

@jcockhren
Copy link
Collaborator Author

jcockhren commented Jun 22, 2021 •
edited
Loading

can you update the PR base branch please? Also I think we will be moving towards AWS deployments @DMalone87 were you able to confirm that?

@JMStudiosJoe Re: PR base branch. This is a PR from a branch on a fork into the main branch of this repo. Should this PR not be merged into main?

@DMalone87
Copy link
Collaborator

can you update the PR base branch please? Also I think we will be moving towards AWS deployments @DMalone87 were you able to confirm that?

@JMStudiosJoe Re: PR base branch. This is a PR from a branch on a fork into the main branch of this repo. Should this PR not be merged into main?

Just removed the update requirement so no issues there.

As for AWS, it was more overall compatibility that was the issue.

DMalone87
DMalone87 approved these changes Jun 22, 2021
View reviewed changes
Copy link
Collaborator

@DMalone87 DMalone87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this up and see if we can get it running on Heroku. We can do the AWS migration at a later date if needed.

@DMalone87 DMalone87 merged commit 382b96f into codeforboston:main Jun 22, 2021
@jcockhren jcockhren deleted the issue67-heroku branch June 23, 2021 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DMalone87 DMalone87 DMalone87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Remove 3rd party GitHub action for heroku deploy
3 participants
@jcockhren @JMStudiosJoe @DMalone87