Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Remove 3rd party GitHub action for heroku deploy #67

Closed
jcockhren opened this issue Jun 22, 2021 · 0 comments · Fixed by #68
Closed

[BUG] Remove 3rd party GitHub action for heroku deploy #67

jcockhren opened this issue Jun 22, 2021 · 0 comments · Fixed by #68
Assignees
Labels
bug Something isn't working

Comments

@jcockhren
Copy link
Collaborator

Describe the bug
The current heroku.yml workflow is designed to use a 3rd party (unverified) action for deployment to Heroku. This project leverages Heroku's new Platform API and container registry.

- uses: akhileshns/[email protected] # This is the action

Code for Boston has not been able to deploy this app successfully using this action. We have not been able to get this action to authenticate with Heroku successfully.

To Reproduce
Steps to reproduce the behavior:

  1. Merge any Pull Request into main
  2. Look at the Actions tab

Expected behavior
When you merge into main, the action should at least successfully authenticate with Heroku and attempt to push a container with the latest app build.

Additional context
Using this 3rd party action should not be necessary given that the Heroku CLI comes preinstalled in Ubuntu images. See supported software

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant