Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Convert the Unit property into a db Unit model #398

Conversation

RyanPark44
Copy link
Collaborator

@RyanPark44 RyanPark44 commented Jun 11, 2024

Converted the unit property, in the Agency Model, into its own Unit Model.
See issue here

Completed

  • Created new Unit Model
  • Established Unit as a child of agency
  • Established an association between Unit and Employment object
  • Updated Employment Model's merge_employment_records to account for Unit model
  • Updated agencies and officers endpoints to reflect change to merge_employment_records
  • Updated schema to include Unit model

To do next

  • Create endpoint for Unit
  • Create tests for Unit

@RyanPark44 RyanPark44 linked an issue Jun 11, 2024 that may be closed by this pull request
Copy link
Collaborator

@DMalone87 DMalone87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks, Ryan.

@RyanPark44 RyanPark44 merged commit a743c23 into codeforboston:main Jun 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Convert the Unit property into a DB Model
2 participants