Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Convert the Unit property into a DB Model #387

Closed
DMalone87 opened this issue May 22, 2024 · 0 comments · Fixed by #398
Closed

[FEATURE] Convert the Unit property into a DB Model #387

DMalone87 opened this issue May 22, 2024 · 0 comments · Fixed by #398
Assignees
Labels
backend enhancement New feature or request good first issue Good for newcomers priority

Comments

@DMalone87
Copy link
Collaborator

DMalone87 commented May 22, 2024

Is your feature request related to a problem? Please describe.
Each police officer working within a police department will be associated with a particular unit. For example, NYPD Officer Kit Yung is a Sergeant in the 9th Precinct.

In our current database structure, a Unit is just a string property of the employment model (See here). In this model, a unit exists between a single officer and a single agency. This doesn't properly represent a world where many officers can belong to the same Unit.

Describe the solution you'd like
We should add a Unit model as a child of an Agency. We can then associate the Unit object with the Employment object, properly representing the relationship.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend enhancement New feature or request good first issue Good for newcomers priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants