Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] Update Incident Model #278

Closed
DMalone87 opened this issue May 21, 2023 · 1 comment
Closed

[REFACTOR] Update Incident Model #278

DMalone87 opened this issue May 21, 2023 · 1 comment
Assignees
@DMalone87

Comments

@DMalone87
Copy link
Collaborator

DMalone87 commented May 21, 2023 •
edited

Is your feature request related to a problem? Please describe.
Our current Incident schema is not compatible with the guideline laid out in the NPDC Incident Model. Since this is the model that we plan to share with coalition partners who want to submit data to us, it's imperative that we follow it ourselves.

Describe the solution you'd like
Update the current incident schema to accord with the proposed incident model.

Additional Context
This change is required before we can tackle Issue #277, Adding a Data Simulation feature.
@DMalone87 DMalone87 self-assigned this May 21, 2023
@DMalone87 DMalone87 mentioned this issue May 24, 2023
Open
DMalone87 added a commit that referenced this issue Jul 8, 2023
@DMalone87
Issue #278 - Refactor Database (#281)
f3320f7 
* Refactor Officer -> Suspect
First step of the refactor is to separate the Officer table from the version that is a child of the incident table. We'll set up a standalone officer and agency table where we'll store records related to known officers and law enforcement agencies. The old officer table, now called Suspects will store information about those officers suspected of committing a crime against the public. The suspect table will be connected to officers via the accusation table.

* Refactor: Source is now parent of incident
 - Remove source from other models
 - Remove SourceMixin

* Many-to-Many Relationships added.
Tags and Agencies linked to Incidents
Suspects and Agencies linked to officers
Style changes.

* Refactor: suspect --> perpetrator

* Flake8 fix

* Update perpetrator backref
Update tests
Flake8 fix

* Additional Refactoring changes

* UI Errors

* UI Test Fixes
- Updated Snapshots
- Update models

* Fix mock data issue

* Continued refactoring

* Mismatched Source ID type

* Update victim table

* Jest corrections

---------

Co-authored-by: Darrell Malone <[email protected]>
@DMalone87
Copy link
Collaborator Author

Completed by PR #281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DMalone87 DMalone87

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DMalone87