Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to full incident view #254

Merged
merged 5 commits into from
Aug 22, 2022
Merged

Add link to full incident view #254

merged 5 commits into from
Aug 22, 2022

Conversation

Logan-Dang
Copy link
Collaborator

@Logan-Dang Logan-Dang commented Aug 13, 2022

How to Test:

Requires Docker

  • Follow build instructions in README.md
  • Once the page is up log in.
  • Enter search terms (Test Location for location).
  • Click the right arrow on one of the entries.
  • View the full record.
    image

Closes #250

@github-actions
Copy link

github-actions bot commented Aug 13, 2022

Visit the preview URL for this PR (updated for commit c0b5a20):

https://police-data-trust-dev--pr254-connect-search-eon8fyos.web.app

(expires Fri, 26 Aug 2022 03:55:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 89ee28768ddf114979e2cf8eddd3746214cf93af

@Logan-Dang
Copy link
Collaborator Author

Logan-Dang commented Aug 18, 2022

A lot of commented code is kept because it can still be used, as the Incident model just needs to be updated. I can work on that in this pr or the next.

A lot of the data is different from the designed incident view because of the modeling.

@Logan-Dang Logan-Dang marked this pull request as ready for review August 19, 2022 04:02
@JMStudiosJoe JMStudiosJoe merged commit daac567 into main Aug 22, 2022
@DMalone87 DMalone87 deleted the connect-search branch June 6, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Connect UI search input and button to call search endpoint
2 participants