Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak add/remove recipients - testimony flow #1402

Closed
mvictor55 opened this issue Jan 4, 2024 · 2 comments · Fixed by #1494
Closed

Tweak add/remove recipients - testimony flow #1402

mvictor55 opened this issue Jan 4, 2024 · 2 comments · Fixed by #1494
Assignees

Comments

@mvictor55
Copy link
Collaborator

mvictor55 commented Jan 4, 2024

Within the "create testimony process", we ask the user to choose what legislators should be contacted with the testimony. By default "to:" box is loaded with 1) the chairs of the relevant committee and; 2) the user's own legislators (senate and rep).
We need to adjust the language and functionality of this.

  1. When the page loads, the relevant committee members are already populated in the recipient box, so it’s strange that the button language says “add”. Instead it should say "remove".
image
  1. When the page loads, currently, the button says “Add Relevant Committee” - but it should specify this is only for “Chairs” and not the whole committee. Instead it should say “Remove Relevant Committee Chairs”, which if clicked, would remove those legislators (see above screenshot)

  2. Dynamic content. If the user hits the button and the legislators are removed, the button text should change to "Add Relevant Committee Chairs.

  3. This logic should also be applied to the "Add My Legislators" button. When the page loads, the legislators names will populate automatically, so the text should say "Remove My Legislators". When that button is clicked and the legislators are removed, the text then changes to "Add My Legislators.

@mvictor55
Copy link
Collaborator Author

Thanks @hanboyu ! Looking forward to reviewing this.

@mvictor55
Copy link
Collaborator Author

Hi @hanboyu this looks great. One request: can you move the "copy recipient" above the text box, and have everything right-aligned like in the figma screenshot above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants