146 fix get report datetime issue #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…int); fix indentation of test
…for dates over 80 days ago. Log a warning in this case.
coddingtonbear
approved these changes
Oct 23, 2022
coddingtonbear
added a commit
that referenced
this pull request
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix datetime/date comparison issue reported in #146
Note that the MFP report URL doesn't appear to return correct data if we're trying to look back too far. For example,
https://www.myfitnesspal.com/reports/results/nutrition/Net%20Calories/90.jsonshould return the last 90 days of net calories, but anything beyond 80 days is incorrect or zero for me.I added a warning for this case.