functionality for getting reports updated #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myfitnesspal/client.py
Outdated
| upper_bound: Optional[datetime.date] = None, | ||
| ) -> Dict[datetime.date, float]: | ||
| """Returns measurements of a given name between two dates.""" | ||
| def _upper_lower_bound_helper(self, lower_bound, upper_bound): |
There was a problem hiding this comment.
Suggested change
| def _upper_lower_bound_helper(self, lower_bound, upper_bound): | |
| def _ensure_upper_lower_bound(self, lower_bound, upper_bound): |
Using verbs to name methods often makes code easier to read
myfitnesspal/client.py
Outdated
| upper_bound: Optional[datetime.date] = None, | ||
| ) -> Dict[datetime.date, float]: | ||
| """Returns measurements of a given name between two dates.""" | ||
| upper_bound, lower_bound = self._upper_lower_bound_helper(lower_bound, upper_bound) |
There was a problem hiding this comment.
Suggested change
| upper_bound, lower_bound = self._upper_lower_bound_helper(lower_bound, upper_bound) | |
| upper_bound, lower_bound = self._ensure_upper_lower_bound(lower_bound, upper_bound) |
myfitnesspal/client.py
Outdated
| """ | ||
| Returns report data of a given name and category between two dates. | ||
| """ | ||
| upper_bound, lower_bound = self._upper_lower_bound_helper(lower_bound, upper_bound) |
There was a problem hiding this comment.
Suggested change
| upper_bound, lower_bound = self._upper_lower_bound_helper(lower_bound, upper_bound) | |
| upper_bound, lower_bound = self._ensure_upper_lower_bound(lower_bound, upper_bound) |
|
thanks for the feedback, updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some refactoring to avoid duplication and fixing some failing tests