Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some objects alignment #344

Merged
merged 3 commits into from
May 8, 2013
Merged

Add some objects alignment #344

merged 3 commits into from
May 8, 2013

Conversation

zhaoboqiang
Copy link
Contributor

Is there any rules should I need to follow?
This feature has some tiny problem:which is the object aligned to.

vlidholt pushed a commit that referenced this pull request May 8, 2013
Add some objects alignment
@vlidholt vlidholt merged commit 16a71a6 into cocos2d:develop May 8, 2013
@vlidholt
Copy link

vlidholt commented May 8, 2013

Thank you for the pull request! Really useful, I made some minor adjustments to the naming of the alignment options. For the alignment left/right/top/right, I think that the objects should align to the outmost object. E.g. for align left, align to the object that has the left-most edge. For size, maybe align sizes to the larger objects? Do you want to fix this? :)

Also, let me know if you want your name/website in the authors file!

@zhaoboqiang
Copy link
Contributor Author

I am happy to hear that.

At the beginning, I want to use the first selected one to be aligned or sized.
There's extra work to adding another highlight state to the aligned one. so I use the last selected one. It's a tradeoff.
But I found it useless sometime. I don't known how to a NSArray insertion work.
I also need some time to learn Object-C.
I need time to become familiar with macos UI habits.

But these two weeks I was busy.

About the anthors file.I am happly to hear that.My contribution is too small.
My original intention was to upgrade the new version without merge.This is a project needs.

If you have a C/C++ version of the plan, I could contribute more.


Born to code,die for bugs.
Zhao Boqiang
22°20'39.85"N 113°34'57.03"E

------------------ 原始邮件 ------------------
发件人: "Viktor Lidholt"[email protected];
发送时间: 2013年5月8日(星期三) 上午9:53
收件人: "cocos2d/CocosBuilder"[email protected];
抄送: "Zhao Boqiang"[email protected];
主题: Re: [CocosBuilder] Add some objects alignment (#344)

Thank you for the pull request! Really useful, I made some minor adjustments to the naming of the alignment options. For the alignment left/right/top/right, I think that the objects should align to the outmost object. E.g. for align left, align to the object that has the left-most edge. For size, maybe align sizes to the larger objects? Do you want to fix this? :)

Also, let me know if you want your name/website in the authors file!


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants