Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional Keypoint OKS sigmas argument #269

Merged
merged 1 commit into from
Apr 2, 2019

Conversation

sampepose
Copy link
Contributor

This change allows adding custom keypoint sigmas to compute keypoint OKS. A real-world use case is computing metrics on extended keypoint models, such as 19 keypoints (adding head-top and chin to the standard COCO 17 keypoints).

@rbgirshick
Copy link
Contributor

I'd like to merge this simple PR to improve support for evaluating custom keypoint datasets that have different keypoint definitions. @pdollar, @tylin, @matteorr any objections?

@matteorr
Copy link

@rbgirshick - It seems fine with me. However, wouldn't it be better to use the params class instead of passing it like that? I.e., take a look at how I did it in the cocoanalyze repo.

coco_eval = COCOeval(coco_gt, coco_dt, 'keypoints')
coco_eval.params.kpt_oks_sigmas = np.array([.26, .25, .25, .35, .35, .79, .79, .72, .72, .62,.62, 1.07, 1.07, .87, .87, .89, .89])/10.0

This way we can keep the init iou_type agnostic.

@pdollar
Copy link
Collaborator

pdollar commented Mar 26, 2019

Sounds good to me. Will let @tylin comment on specifics for the python version of the API.

@sampepose
Copy link
Contributor Author

Do you want any more changes, @tylin / @matteorr?

@matteorr
Copy link

Everything looks fine to me! Thanks for doing this.

@tylin tylin merged commit aca78bc into cocodataset:master Apr 2, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants