Makman2/linterups #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 20, 2016
| @@ -205,6 +205,10 @@ We can test our bear like this | |||
| by their **filename** and display them based on their | |||
| **classname**. | |||
|
|
|||
| Normally, providing a severity-map is not needed, as *coala* has a default | |||
There was a problem hiding this comment.
nooo no more italic on coala, i have taken thoughts and we dont want that :D
Makman2
force-pushed
the
Makman2/linterups
branch
2 times, most recently
from
e7a3979
to
c0336f8
Compare
|
ack c0336f8 |
| @@ -71,6 +71,17 @@ You can use these parameters to construct the command line arguments. The | |||
| linter expects from you to return an argument sequence here. A tuple is | |||
| preferred. We will do this soon for ``PylintTutorialBear``. | |||
|
|
|||
| .. note:: | |||
|
|
|||
| ``create_arguments`` can also be a non-staticmethod. In this case you also | |||
There was a problem hiding this comment.
isnt it non-static method as in two words?
There was a problem hiding this comment.
I wanted to refer to the @staticmethod decorator. Though yes you are right, this is no good english :3
I'll rephrase to
create_argumentsdoesn't have to be a static method.
|
ack f1aa603 |
| "value=2 = 2") | ||
| return config_file | ||
|
|
||
| The string returned from this method is written into a temporary file before |
|
ack 88260f0 |
|
ack a7c0789 |
Default severities are written down at the API documentation and also maintained there.
This was documentation on the deprecated API.
It adds absolutely no information at all.
"that" is always restrictive in use, that's why it never takes a comma before it. Also use "which" in one place, as the sentence indicates nonrestrictive information.
Mention non-staticmethod'ness for `create_arguments()`.
Makman2
force-pushed
the
Makman2/linterups
branch
from
c0336f8
to
a68d618
Compare
|
ack d2a8df2 |
|
@rultor merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.