Getting_In_Touch.rst: Add COC reference link. #561

chhabrabhishek · 2018-06-20T15:21:39Z

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

I read the commit guidelines and I've followed
them.
I ran coala over my code locally. (All commits have to pass
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

pick up any PR at https://coala.io/review
review it (check https://coala.io/reviewing for more info)
if you are sure that it needs work, use corobo mark wip <URL> to get it out
of the review queue.

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

nvzard

@chhabrabhishek please read the commit guidelines and edit your commit message accordingly.

Also, add issue link in you commit message.

saksham189

Commit message is still incorrect. Use git commit --amend to change it and read the commit guidelines. Look at some of the examples here and ask if you have any doubts
http:https://api.coala.io/en/latest/Developers/Writing_Good_Commits.html

chhabrabhishek · 2018-06-20T15:42:40Z

@anctartica is my commit incorrect syntactically or logically? I mean do I have a need to correct the content written in it or am I commiting it incorrectly?

pareksha

The issue corresponding to your PR isn't a bug. Use Closes instead of Fixes in your commit message.
Also in the shortlog, use Add instead of Added.

ankitxjoshi · 2018-06-20T16:14:37Z

Update Added to Add. You can refer this to understand why.

jayvdb · 2018-06-20T23:59:16Z

Help/Getting_In_Touch.rst

@@ -24,3 +24,6 @@ Modularity, clean good code as well as a high usability for both users
 and developers of analyse routines (called bears) stand in the
 foreground of the development. We will not speed up our development if
 it needs sacrificing any aspect of quality.
+
+
+Please follow our Code Of Conduct, you can find it `here <http:https://docs.coala.io/en/latest/Help/FAQ.html#what-is-coala-community-code-of-conduct>`__.


This page is about contacting people.

This should be after "- Give us feedback", as a new item,

Report any Code of Conduct violations to ....

ksdme

@chhabrabhishek While we are at it please update the commit message body, it would look better if it says something like Introduce feedback section and adds CoC reference.

gitmate-bot · 2018-06-21T04:16:47Z

Help/Getting_In_Touch.rst

+Give Us Feedback
+================
+
+- Report any `Code Of Conduct <http:https://docs.coala.io/en/latest/Help/FAQ.html#what-is-coala-community-code-of-conduct>`__ 


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: docs.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpy96jet4g/Help/Getting_In_Touch.rst +++ b/tmp/tmpy96jet4g/Help/Getting_In_Touch.rst @@ -29,5 +29,5 @@ Give Us Feedback ================ -- Report any `Code Of Conduct <http:https://docs.coala.io/en/latest/Help/FAQ.html#what-is-coala-community-code-of-conduct>`__ +- Report any `Code Of Conduct <http:https://docs.coala.io/en/latest/Help/FAQ.html#what-is-coala-community-code-of-conduct>`__ violations to ``community AT coala DOT io``.

saksham189 · 2018-06-21T05:03:19Z

Help/.coafile

+[cli]
+bears = SpaceConsistencyBear
+files = Getting_In_Touch.rst
+use_spaces = True


don't need this. Why have you added a .coafile here? There is already one in the project that has the SpaceConsistencyBear

@anctartica I did'nt added this file, I just ran the coala's space consistency bear on Getting_In_Touch.rst file and this .coafile generated automatically.Do I remove it?

please remove it from the commit

saksham189 · 2018-06-21T05:14:00Z

Help/Getting_In_Touch.rst

@@ -24,3 +24,10 @@ Modularity, clean good code as well as a high usability for both users
 and developers of analyse routines (called bears) stand in the
 foreground of the development. We will not speed up our development if
 it needs sacrificing any aspect of quality.
+
+
+Give Us Feedback


Add the point below here: https://github.com/coala/documentation/pull/561/files#diff-15cbcde0631d4f2a91a45e04d0318b85R16

don't need a new section

but @anctartica can you see what @jayvdb had reviewed
he said me to add a new section

@anctartica is it correct or does it need any changes?

he never mentioned a new section.

This should be after "- Give us feedback", as a new item

add a new point below the "- Give us feedback" point

and do i have to write report at community AT coala DOT io
or do I simply write report at gitter and mail

If you believe someone is violating the code of conduct, we ask that you report it by emailing community AT coala DOT io.

this is mentioned in COC

Is it correct now? Or does it need any changes?

chhabrabhishek

`

Add CoC violation reporting email. Closes coala#553

ksdme · 2018-06-21T07:12:04Z

Any opinion on if we should should have a wrapped link - If you believe someone is violating the code of conduct <http:https://docs.coala.io/en/latest/Help/FAQ.html#what-is-coala-community-code-of-conduct>__ to maintain line length?

jayvdb · 2018-06-21T15:55:44Z

ack c596e8b

jayvdb · 2018-06-21T15:55:53Z

@gitmate-bot ff

gitmate-bot · 2018-06-21T15:55:56Z

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

jayvdb · 2018-06-21T15:57:47Z

While line length is important, this was a good attempt at balancing line length and readibility factors, The result is mergable for user-docs. I probably would have been stricter in dev-docs ;-)

gitmate-bot · 2018-06-21T15:57:50Z

Automated fastforward with GitMate.io was successful! 🎉

gitmate-bot added process/pending review size/XS labels Jun 20, 2018

nvzard suggested changes Jun 20, 2018

View reviewed changes

chhabrabhishek force-pushed the coala_abhishek branch from e807ab4 to 2b95170 Compare June 20, 2018 15:36

gitmate-bot added difficulty/newcomer importance/medium labels Jun 20, 2018

gitmate-bot assigned chhabrabhishek Jun 20, 2018

saksham189 reviewed Jun 20, 2018

View reviewed changes

chhabrabhishek force-pushed the coala_abhishek branch from 2b95170 to 7e04e8b Compare June 20, 2018 15:52

pareksha suggested changes Jun 20, 2018

View reviewed changes

chhabrabhishek force-pushed the coala_abhishek branch from 7e04e8b to 95162c3 Compare June 20, 2018 16:11

chhabrabhishek force-pushed the coala_abhishek branch from 95162c3 to b111137 Compare June 20, 2018 16:16

chhabrabhishek changed the title ~~Getting_In_Touch.rst: Added reference link for COC~~ Getting_In_Touch.rst: Add COC reference link. Jun 20, 2018

chhabrabhishek force-pushed the coala_abhishek branch from b111137 to bcade48 Compare June 20, 2018 17:19

jayvdb requested changes Jun 20, 2018

View reviewed changes

jayvdb added process/wip and removed process/pending review labels Jun 20, 2018

ksdme suggested changes Jun 21, 2018

View reviewed changes

chhabrabhishek force-pushed the coala_abhishek branch from bcade48 to 4649811 Compare June 21, 2018 04:12

gitmate-bot added process/pending review and removed process/wip labels Jun 21, 2018

gitmate-bot reviewed Jun 21, 2018

View reviewed changes

chhabrabhishek force-pushed the coala_abhishek branch from 4649811 to 60b393e Compare June 21, 2018 04:22

saksham189 reviewed Jun 21, 2018

View reviewed changes

chhabrabhishek force-pushed the coala_abhishek branch from 60b393e to c0fa2a0 Compare June 21, 2018 05:17

chhabrabhishek commented Jun 21, 2018

View reviewed changes

chhabrabhishek force-pushed the coala_abhishek branch from c0fa2a0 to 2a73888 Compare June 21, 2018 06:29

chhabrabhishek force-pushed the coala_abhishek branch from 2a73888 to 0aff9f7 Compare June 21, 2018 06:57

Getting_In_Touch.rst: Add COC reference link

c596e8b

Add CoC violation reporting email. Closes coala#553

chhabrabhishek force-pushed the coala_abhishek branch from 0aff9f7 to c596e8b Compare June 21, 2018 06:58

jayvdb approved these changes Jun 21, 2018

View reviewed changes

gitmate-bot added process/approved and removed process/pending review labels Jun 21, 2018

gitmate-bot merged commit c596e8b into coala:master Jun 21, 2018

gitmate-bot removed the process/approved label Jun 21, 2018

gitmate-bot added process/approved and removed process/approved labels Jun 21, 2018

chhabrabhishek deleted the coala_abhishek branch July 7, 2018 06:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Getting_In_Touch.rst: Add COC reference link. #561

Getting_In_Touch.rst: Add COC reference link. #561

chhabrabhishek commented Jun 20, 2018 •

edited

Loading

nvzard left a comment •

edited

Loading

saksham189 left a comment •

edited

Loading

chhabrabhishek commented Jun 20, 2018

pareksha left a comment •

edited

Loading

ankitxjoshi commented Jun 20, 2018

jayvdb Jun 20, 2018

ksdme left a comment •

edited

Loading

gitmate-bot Jun 21, 2018

saksham189 Jun 21, 2018

chhabrabhishek Jun 21, 2018 •

edited

Loading

saksham189 Jun 21, 2018

saksham189 Jun 21, 2018

saksham189 Jun 21, 2018

chhabrabhishek Jun 21, 2018

chhabrabhishek Jun 21, 2018

saksham189 Jun 21, 2018

saksham189 Jun 21, 2018

chhabrabhishek Jun 21, 2018

saksham189 Jun 21, 2018

saksham189 Jun 21, 2018

chhabrabhishek Jun 21, 2018

chhabrabhishek left a comment •

edited

Loading

ksdme commented Jun 21, 2018

jayvdb commented Jun 21, 2018

jayvdb commented Jun 21, 2018

gitmate-bot commented Jun 21, 2018

jayvdb commented Jun 21, 2018

gitmate-bot commented Jun 21, 2018

Getting_In_Touch.rst: Add COC reference link. #561

Getting_In_Touch.rst: Add COC reference link. #561

Conversation

chhabrabhishek commented Jun 20, 2018 • edited Loading

Checklist

nvzard left a comment • edited Loading

Choose a reason for hiding this comment

saksham189 left a comment • edited Loading

Choose a reason for hiding this comment

chhabrabhishek commented Jun 20, 2018

pareksha left a comment • edited Loading

Choose a reason for hiding this comment

ankitxjoshi commented Jun 20, 2018

Choose a reason for hiding this comment

ksdme left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chhabrabhishek Jun 21, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chhabrabhishek left a comment • edited Loading

Choose a reason for hiding this comment

ksdme commented Jun 21, 2018

jayvdb commented Jun 21, 2018

jayvdb commented Jun 21, 2018

gitmate-bot commented Jun 21, 2018

jayvdb commented Jun 21, 2018

gitmate-bot commented Jun 21, 2018

chhabrabhishek commented Jun 20, 2018 •

edited

Loading

nvzard left a comment •

edited

Loading

saksham189 left a comment •

edited

Loading

pareksha left a comment •

edited

Loading

ksdme left a comment •

edited

Loading

chhabrabhishek Jun 21, 2018 •

edited

Loading

chhabrabhishek left a comment •

edited

Loading