Use moban templates and assets #560
Conversation
| @@ -5,17 +5,17 @@ | |||
| * Custom stylesheet | |||
| * | |||
| */ | |||
| @import url('https://fonts.googleapis.com/css?family=Roboto:100,300,300i,400,500,700,900'); | |||
| @import url('https://fonts.googleapis.com/css?family=Roboto:100,300,300i,400,500,700,900'); /* Ignore CSSLintBear */ | |||
There was a problem hiding this comment.
these additions are because this repo's .coafile doesnt have csslint enabled.
And this PR would allow that to be added to .coafile.
| @@ -14,8 +14,7 @@ | |||
| height="48px" | |||
| id="svg2985" | |||
| version="1.1" | |||
| viewbox="0 0 48 48" | |||
| inkscape:version="0.91 r13725" | |||
| inkscape:version="0.92.3 (2405546, 2018-03-11)" | |||
There was a problem hiding this comment.
see #558 and coala/artwork#33
.moban.yaml
Outdated
| targets: | ||
| - requirements.txt: requirements.txt.jj2 | ||
| copy: | ||
| - docs-requirements.txt: docs/docs-requirements.txt |
There was a problem hiding this comment.
Why are these files being copied to a new doc folder? I am guessing this removes _static folder and creates a doc folder for all static files and docs-requirements.txt but not understanding why this segregation in being removed?
There was a problem hiding this comment.
These copy from docs/docs-requirements.txt to docs-requirements.txt.
Please re-review @kriti21 .
|
ack 2d72dd4 |
Rultor is no longer used.
|
reack dae51e4 |
|
@gitmate-bot ff |
|
Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently |
|
Automated fastforward with GitMate.io was successful! 🎉 |
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
corobo mark wip <URL>to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!