Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAQ.rst: Add item about CoC #555

Merged
merged 1 commit into from
May 2, 2018
Merged

Conversation

PrajwalM2212
Copy link
Member

@PrajwalM2212 PrajwalM2212 commented May 1, 2018

This adds Code of Conduct item to FAQ.

Closes #554

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

Help/FAQ.rst Outdated
What is coala Community Code of Conduct?
----------------------------------------

Like the technical community as a whole, the coala team and community is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please dont include the entire CoC.

Only an item about the CoC, so people know we have one, and how to find it.

@TravisBuddy
Copy link

Travis tests have failed

Hey @PrajwalM2212,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

make html SPHINXOPTS=-W
sphinx-build -b html -d _build/doctrees  -W . _build/html
Running Sphinx v1.4.9
making output directory...
loading pickled environment... not yet created
building [mo]: targets for 0 po files that are out of date
building [html]: targets for 13 source files that are out of date
updating environment: 13 added, 0 changed, 0 removed
reading sources... [100%] index

Warning, treated as error:
/home/travis/build/coala/documentation/Help/FAQ.rst:2: WARNING: Duplicate explicit target name: "here".

make: *** [html] Error 1

@PrajwalM2212
Copy link
Member Author

@jayvdb I have made the changes. I have trimmed the CoC to include only the must have details. Do tell me if I need to shorten it even more.

Help/FAQ.rst Outdated
----------------------------------------

The coala team and community is made up of a mixture of
professionals and volunteers from all over the world.Diversity is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add space after .

Help/FAQ.rst Outdated

- **When we disagree, try to understand why.**

For more information refer `here <http:https://coala.io/coc>`__.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avoid "here" as a link text.

This adds Code of Conduct item to FAQ.

coala#554
@PrajwalM2212
Copy link
Member Author

@jayvdb I have made the changes.

@jayvdb
Copy link
Member

jayvdb commented May 2, 2018

ack 08e73b5

@jayvdb
Copy link
Member

jayvdb commented May 2, 2018

@gitmate-bot ff

@gitmate-bot
Copy link

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

@gitmate-bot
Copy link

Automated fastforward with GitMate.io was successful! 🎉

@gitmate-bot gitmate-bot merged commit 08e73b5 into coala:master May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

FAQ: Add item about CoC
4 participants