Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install.rst: Fix docs failing build #542

Merged
merged 1 commit into from
Mar 10, 2018

Conversation

alphadose
Copy link
Member

@alphadose alphadose commented Feb 28, 2018

Change dependency installation source from
docs-requirements.txt to requirements.txt

Closes coala/coala#5212

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

@tanhengyeow
Copy link
Member

Conforms to standard.

LGTM 👍

@Makman2
Copy link
Member

Makman2 commented Mar 4, 2018

Hm "Fix docs failing build", you rather correct the command mentioned in the docs, not some build here. Maybe "Fix requirements install command"?

@jayvdb
Copy link
Member

jayvdb commented Mar 10, 2018

@gitmate-bot rebase

Change dependency installation source from
docs-requirements.txt to requirements.txt

Closes coala#543
@gitmate-bot
Copy link

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@gitmate-bot
Copy link

Automated rebase with GitMate.io was successful! 🎉

@jayvdb
Copy link
Member

jayvdb commented Mar 10, 2018

Absolutely agree with @Makman2 that the shortlog of this commit is crap, but it should have been fixed already, so I'm merging anyway

@jayvdb
Copy link
Member

jayvdb commented Mar 10, 2018

ack 08299cd

@jayvdb
Copy link
Member

jayvdb commented Mar 10, 2018

ack e2d575f

@jayvdb
Copy link
Member

jayvdb commented Mar 10, 2018

@gitmate-bot ff

@gitmate-bot
Copy link

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

@gitmate-bot
Copy link

Automated fastforward with GitMate.io was successful! 🎉

@gitmate-bot gitmate-bot merged commit e2d575f into coala:master Mar 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

README.rst: docs build status is red
5 participants