Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install.rst: Install virtualenv with --user #525

Closed
wants to merge 2 commits into from
Closed

Install.rst: Install virtualenv with --user #525

wants to merge 2 commits into from

Conversation

lilithxxx
Copy link

@lilithxxx lilithxxx commented Jan 28, 2018

Updates documentation to tell user to Install virtualenv with --user and how to check whether its already installed.

Closes coala/coala#4017

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

Copy link
Contributor

@newbazz newbazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You havent followed the commit guidelines ;)

@lilithxxx
Copy link
Author

@newbazz What needs to be resolved?

Copy link
Contributor

@newbazz newbazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the commit guidelines and follow them https://api.coala.io/en/latest/Developers/Writing_Good_Commits.html

Users/Install.rst Show resolved Hide resolved
$ virtualenv --version

If you see a version number, its already installed. If you do
not, this can be done with pip3 easily:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to explain the use of --user flag.

Copy link
Member

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls squash your two commits into a single commit.

@jayvdb
Copy link
Member

jayvdb commented Apr 28, 2018

@gitmate-bot rebase

@gitmate-bot
Copy link

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

Rishav Chakraborty added 2 commits April 28, 2018 01:12
Updates documentation to tell user to Install virtualenv with --user and how to check whether its already installed.

Closes coala/coala#4017
Updates documentation to tell user to Install virtualenv with --user and how to check whether its already installed.

Closes coala/coala#4017
@gitmate-bot
Copy link

Automated rebase with GitMate.io was successful! 🎉

Copy link
Member

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small fix, and please squash your commits, and rebase.


$ pip3 install --user virtualenv

The ```--user``` tag is required to install it with root access.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with -> without

@lilithxxx lilithxxx closed this Sep 28, 2019
@lilithxxx lilithxxx deleted the virt branch September 28, 2019 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Development_Setup.html: Tell Unix users that they probably need to install virtualenv with --user
6 participants