Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add slashes #490

Closed
wants to merge 2 commits into from
Closed

add slashes #490

wants to merge 2 commits into from

Conversation

KrishMunot
Copy link
Member

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

@jayvdb
Copy link
Member

jayvdb commented Nov 6, 2017

Literal values should be quoted as literals. See RST documentation.

Copy link
Member

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix literals

Copy link
Contributor

@newbazz newbazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the commit guide lines and re write the commit message.

paths platform independent), use double-backslashes if you really mean a
As the backslash (``\``) is the escape character it is recommended to use
forward slashes (``/``) as path separator even on Windows (to keep relative
paths platform independent), use double-backslashes (``\\``) if you really mean a

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is longer than allowed. (81 > 79)

Origin: LineLengthBear, Section: docs.

Copy link
Member

@khanchi97 khanchi97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow our commit guidelines, you can find it here https://api.coala.io/en/latest/Developers/Writing_Good_Commits.html
And at last, don't forget to squash your commits

paths platform independent), use double-backslashes if you really mean a
As the backslash (``\``) is the escape character it is recommended to use
forward slashes (``/``) as path separator even on Windows (to keep relative
paths platform independent), use double-backslashes (``\\``) if you really mean a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line length should not be greater than 79 characters

Copy link
Contributor

@newbazz newbazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should always be one commit.

Copy link
Contributor

@newbazz newbazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

squash your commits.

@palash25
Copy link
Member

ping @KrishMunot can you please make the suggested changes

@jayvdb jayvdb mentioned this pull request Oct 13, 2018
@jayvdb
Copy link
Member

jayvdb commented Oct 13, 2018

Abandoned PR.

@jayvdb jayvdb closed this Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

7 participants