-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated "What does coala do (for me)?" #299
Conversation
Thanks for your contribution! Reviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.
As you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well! |
- Make it easy to write new routines by offering the interface part | ||
and everything but the actual analyzer routine. | ||
LibreOffice Writer to spellcheck something in English but to spellcheck | ||
something in Spanish is pretty different. That is what coala tries to fix. Just |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is longer than allowed. (80 > 79)
LineLengthBear, severity NORMAL, section docs
.
hey could you please fix the gitmate issues? also, you need a rebase (use |
your commit message needs some work too, please see coala.io/commit for more information about our guidelines :) thanks! |
- Make it easy to write new routines by offering the interface part | ||
and everything but the actual analyzer routine. | ||
LibreOffice Writer to spellcheck something in English but to spellcheck | ||
something in Spanish is pretty different. That is what coala tries to fix. Just |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is longer than allowed. (80 > 79)
LineLengthBear, severity NORMAL, section docs
.
actually just want another analyzing routine? Thats what bears are for. You | ||
want to use clang or pylint on your project? We got you covered. One command | ||
LibreOffice Writer to spellcheck something in English but to spellcheck | ||
something in Spanish is pretty different. That is what coala tries to fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains following spacing inconsistencies:
- Trailing whitespaces.
SpaceConsistencyBear, severity NORMAL, section docs
.
The issue can be fixed by applying the following patch:
--- a/Help/FAQ.rst
+++ b/Help/FAQ.rst
@@ -11,7 +11,7 @@
LibreOffice Writer to spellcheck something in English but to spellcheck
something in Spanish is pretty different. That is what coala tries to fix.
Just use bears for another analyzing routine, without having to write it
-again. You want to use clang or pylint on your project, just one command
+again. You want to use clang or pylint on your project, just one command
and one configuration to lint all languages in your project.
You have an awesome idea for a new kind of code analysis, write just the
@Adrianzatreanu sorry about the mistakes. I'm new so still getting a hang of it. I'm trying to rectify them without any delay. |
no need to hurry ;p this is what newcomer issues are for, you getting accustomed to these problems :) :p |
@Warewolf96 Try running coala from the root directory before submitting the PR. There is a coafile in the root directory. |
ohk thanks @srisankethu |
- Make it easy to write new routines by offering the interface part | ||
and everything but the actual analyzer routine. | ||
LibreOffice Writer to spellcheck something in English but to spellcheck | ||
something in Spanish is pretty different. That is what coala tries to fix. Just |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is longer than allowed. (80 > 79)
LineLengthBear, severity NORMAL, section docs
.
actually just want another analyzing routine? Thats what bears are for. You | ||
want to use clang or pylint on your project? We got you covered. One command | ||
LibreOffice Writer to spellcheck something in English but to spellcheck | ||
something in Spanish is pretty different. That is what coala tries to fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains following spacing inconsistencies:
- Trailing whitespaces.
SpaceConsistencyBear, severity NORMAL, section docs
.
The issue can be fixed by applying the following patch:
--- a/Help/FAQ.rst
+++ b/Help/FAQ.rst
@@ -11,7 +11,7 @@
LibreOffice Writer to spellcheck something in English but to spellcheck
something in Spanish is pretty different. That is what coala tries to fix.
Just use bears for another analyzing routine, without having to write it
-again. You want to use clang or pylint on your project, just one command
+again. You want to use clang or pylint on your project, just one command
and one configuration to lint all languages in your project.
You have an awesome idea for a new kind of code analysis, write just the
Can you squash your commits together? Use the |
and be sure to run coala locally to get rid of all those issues |
@sils ohk... i'm a little busy for around 6-7 hours, i'll complete this within 10 hours or so. |
@sils Hey, if u r not busy can u please review this... |
Hi, if you want to speed up reviews, consider helping us reviewing code yourself! |
actually just want another analyzing routine? Thats what bears are for. You | ||
want to use clang or pylint on your project? We got you covered. One command | ||
LibreOffice Writer to spellcheck something in English but to spellcheck | ||
something in Spanish con't be done in same. That is what coala tries to fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also it's not like coala fixes libreoffice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on it...
not fully convinced of the summary yet, it's very hard to sum this up properly though :/ maybe the community on the chat can help you create a better one |
I don't have concrete ideas on how to improve other that I think this isn't good enough for most people to understand it. |
@sils ok, I'll get help on chat and how to review code proposed by other contributors...? |
fbc7554
to
8418d6c
Compare
sorry, still not a fan of the commit. More text and you remove the part that did the best summary for me previously. |
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
6 similar comments
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
8418d6c
to
41302df
Compare
Fixes #289