Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated "What does coala do (for me)?" #299

Closed
wants to merge 0 commits into from

Conversation

parthbeingparth
Copy link
Contributor

@parthbeingparth parthbeingparth commented Nov 13, 2016

Fixes #289

@gitmate-bot
Copy link

Thanks for your contribution!

Reviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.

As you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well!

- Make it easy to write new routines by offering the interface part
and everything but the actual analyzer routine.
LibreOffice Writer to spellcheck something in English but to spellcheck
something in Spanish is pretty different. That is what coala tries to fix. Just

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is longer than allowed. (80 > 79)

LineLengthBear, severity NORMAL, section docs.

@Adrianzatreanu
Copy link
Contributor

hey could you please fix the gitmate issues? also, you need a rebase (use cobot explain rebase on gitter if you need help)

@Adrianzatreanu
Copy link
Contributor

your commit message needs some work too, please see coala.io/commit for more information about our guidelines :) thanks!

- Make it easy to write new routines by offering the interface part
and everything but the actual analyzer routine.
LibreOffice Writer to spellcheck something in English but to spellcheck
something in Spanish is pretty different. That is what coala tries to fix. Just

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is longer than allowed. (80 > 79)

LineLengthBear, severity NORMAL, section docs.

actually just want another analyzing routine? Thats what bears are for. You
want to use clang or pylint on your project? We got you covered. One command
LibreOffice Writer to spellcheck something in English but to spellcheck
something in Spanish is pretty different. That is what coala tries to fix.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line contains following spacing inconsistencies:

  • Trailing whitespaces.

SpaceConsistencyBear, severity NORMAL, section docs.

The issue can be fixed by applying the following patch:

--- a/Help/FAQ.rst
+++ b/Help/FAQ.rst
@@ -11,7 +11,7 @@
 LibreOffice Writer to spellcheck something in English but to spellcheck
 something in Spanish is pretty different. That is what coala  tries to fix. 
 Just use bears for another analyzing routine, without having to write it 
-again. You want to use clang or pylint on your project, just one command 
+again. You want to use clang or pylint on your project, just one command
 and one configuration to lint all languages in your project.

 You have an awesome idea for a new kind of code analysis, write just the

@parthbeingparth
Copy link
Contributor Author

@Adrianzatreanu sorry about the mistakes. I'm new so still getting a hang of it. I'm trying to rectify them without any delay.

@Adrianzatreanu
Copy link
Contributor

no need to hurry ;p this is what newcomer issues are for, you getting accustomed to these problems :) :p
you still have 3 more issues and need a rebase btw

@srisankethu
Copy link
Member

@Warewolf96 Try running coala from the root directory before submitting the PR. There is a coafile in the root directory.

@parthbeingparth
Copy link
Contributor Author

ohk thanks @srisankethu

- Make it easy to write new routines by offering the interface part
and everything but the actual analyzer routine.
LibreOffice Writer to spellcheck something in English but to spellcheck
something in Spanish is pretty different. That is what coala tries to fix. Just

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is longer than allowed. (80 > 79)

LineLengthBear, severity NORMAL, section docs.

actually just want another analyzing routine? Thats what bears are for. You
want to use clang or pylint on your project? We got you covered. One command
LibreOffice Writer to spellcheck something in English but to spellcheck
something in Spanish is pretty different. That is what coala tries to fix.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line contains following spacing inconsistencies:

  • Trailing whitespaces.

SpaceConsistencyBear, severity NORMAL, section docs.

The issue can be fixed by applying the following patch:

--- a/Help/FAQ.rst
+++ b/Help/FAQ.rst
@@ -11,7 +11,7 @@
 LibreOffice Writer to spellcheck something in English but to spellcheck
 something in Spanish is pretty different. That is what coala  tries to fix. 
 Just use bears for another analyzing routine, without having to write it 
-again. You want to use clang or pylint on your project, just one command 
+again. You want to use clang or pylint on your project, just one command
 and one configuration to lint all languages in your project.

 You have an awesome idea for a new kind of code analysis, write just the

@sils
Copy link
Member

sils commented Nov 14, 2016

Can you squash your commits together? Use the git rebase --interactive - google for it if you don't know it :)

@sils
Copy link
Member

sils commented Nov 14, 2016

and be sure to run coala locally to get rid of all those issues

@parthbeingparth
Copy link
Contributor Author

@sils ohk... i'm a little busy for around 6-7 hours, i'll complete this within 10 hours or so.

@parthbeingparth
Copy link
Contributor Author

@sils Hey, if u r not busy can u please review this...

@sils
Copy link
Member

sils commented Dec 12, 2016

Hi, if you want to speed up reviews, consider helping us reviewing code yourself!

actually just want another analyzing routine? Thats what bears are for. You
want to use clang or pylint on your project? We got you covered. One command
LibreOffice Writer to spellcheck something in English but to spellcheck
something in Spanish con't be done in same. That is what coala tries to fix.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also it's not like coala fixes libreoffice

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on it...

@sils
Copy link
Member

sils commented Dec 12, 2016

not fully convinced of the summary yet, it's very hard to sum this up properly though :/ maybe the community on the chat can help you create a better one

@sils
Copy link
Member

sils commented Dec 12, 2016

I don't have concrete ideas on how to improve other that I think this isn't good enough for most people to understand it.

@parthbeingparth
Copy link
Contributor Author

parthbeingparth commented Dec 12, 2016

@sils ok, I'll get help on chat and how to review code proposed by other contributors...?

@sils
Copy link
Member

sils commented Dec 13, 2016

sorry, still not a fan of the commit. More text and you remove the part that did the best summary for me previously.

@gitmate-bot
Copy link

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

6 similar comments
@gitmate-bot
Copy link

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

@gitmate-bot
Copy link

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

@gitmate-bot
Copy link

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

@gitmate-bot
Copy link

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

@gitmate-bot
Copy link

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

@gitmate-bot
Copy link

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet