Install.rst: Add post-Java installation info #269
Conversation
|
Thanks for your contribution! Reviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.
As you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well! |
| @@ -70,6 +70,8 @@ To install coala only (without any bears), you can do: | |||
|
|
|||
| $ pip3 install coala | |||
|
|
|||
| If, after installing coala, you install Java (information for downloading Java for all majors OS can be found `here <https://www.java.com/en/download/help/download_options.xml>`_.), you must restart your shell. This is to inform coala that Java has been installed. | |||
There was a problem hiding this comment.
Line contains following spacing inconsistencies:
- Trailing whitespaces.
SpaceConsistencyBear, severity NORMAL, section docs.
The issue can be fixed by applying the following patch:
--- a/Users/Install.rst
+++ b/Users/Install.rst
@@ -70,7 +70,7 @@
$ pip3 install coala
-If, after installing coala, you install Java (information for downloading Java for all majors OS can be found `here <https://www.java.com/en/download/help/download_options.xml>`_.), you must restart your shell. This is to inform coala that Java has been installed.
+If, after installing coala, you install Java (information for downloading Java for all majors OS can be found `here <https://www.java.com/en/download/help/download_options.xml>`_.), you must restart your shell. This is to inform coala that Java has been installed.
Installing inside a virtualenvThere was a problem hiding this comment.
also this line is way too long, why doesn't gitmate catch that as well :/
There was a problem hiding this comment.
so I'd make this a note and make the phrasing a bit less complicated, shorter and include reasoning for needing java because a lot of people don't like it, how about something along the lines of:
Be sure to have java installed if you install the coala-bears package. You might need to restart your shell after installing it so coala picks it up. Java is needed for our grammar checking analysis routines.
Asks user to restart the shell after Java is installed to let coala know about the same. Closes #259
| Install.rst: Add post-Java installation info | ||
| .. note:: | ||
|
|
||
| Make sure that you have **Java** installed if you install the coala-bears package. You might need to restart your shell after installing it so that coala picks it up. Java is needed for our grammar checking analysis routines. |
There was a problem hiding this comment.
Line is longer than allowed. (237 > 79)
LineLengthBear, severity NORMAL, section docs.
| Install.rst: Add post-Java installation info | ||
| .. note:: | ||
|
|
||
| Make sure that you have **Java** installed if you install the coala-bears package. You might need to restart your shell after installing it so that coala picks it up. Java is needed for our grammar checking analysis routines. |
There was a problem hiding this comment.
Line contains following spacing inconsistencies:
- Trailing whitespaces.
SpaceConsistencyBear, severity NORMAL, section docs.
The issue can be fixed by applying the following patch:
--- a/Users/Install.rst
+++ b/Users/Install.rst
@@ -73,7 +73,7 @@
Install.rst: Add post-Java installation info
.. note::
- Make sure that you have **Java** installed if you install the coala-bears package. You might need to restart your shell after installing it so that coala picks it up. Java is needed for our grammar checking analysis routines.
+ Make sure that you have **Java** installed if you install the coala-bears package. You might need to restart your shell after installing it so that coala picks it up. Java is needed for our grammar checking analysis routines.
Installing inside a virtualenv| Install.rst: Add post-Java installation info | ||
| .. note:: | ||
|
|
||
| Make sure that you have **Java** installed if you install the coala-bears package. You might need to restart your shell after installing it so that coala picks it up. Java is needed for our grammar checking analysis routines. |
There was a problem hiding this comment.
i dont think the restart is needed for coala to pick it up, but for the terminal to pick it up. or at least thats how it is when you add something ot the PATH on linux
There was a problem hiding this comment.
@Adrianzatreanu But coala reads the java location from $PATH no?
|
@AbdealiJK no, cib has been staled for 2 months by fabian, i will start working on it again this weekend i think, i dont want to suggest anyone to use it yet :) |
|
also, please fix your gitmate issues, thanks! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
4 similar comments
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
@hi023 status update on this? |
|
@Mixih Hey! Could you please assign another contributor for this task? Really wound up in Course work. Sorry about it! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
4 similar comments
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
closing as requested :) |
Asks user to restart the shell after Java is
installed to let coala know about the same.
Closes #259