Fixed issue #164 #165

prisas · 2016-10-08T17:06:09Z

I have added as notes the information asked in the issue #164

gitmate-bot · 2016-10-08T17:06:21Z

Thanks for your contribution!

Reviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.

I have rebased properly. Please see this for a tutorial.
I have gone through the commit guidelines and I've followed them:
- I have followed the guidelines for the commit shortlog.
- I have followed the guidelines for the commit body.
- I have included the issue URL.
- I have used the Fixes keyword if the commit fixes a real bug and the Closes keyword if it adds a feature/enhancement. See more here.
I have run all the tests and they all pass. That includes that all CI (below) is green - if GitMate issues appear you will have to amend your commits, pushing new commits on top is not sufficient!

As you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well!

meetmangukiya · 2016-10-08T17:12:12Z

Please amend the commit to meet the guidelines of https://coala.readthedocs.io/en/latest/Developers/Writing_Good_Commits.html

Essentially, you have to have the short log something more better then just Fixed issue #165

meetmangukiya · 2016-10-08T17:13:26Z

Developers/Newcomers_Guide.rst

+
+ The first thing you should do is check other developers' pull requests to get the 
+ hang of things.
+ You should also start working on low level issues or help us with artwork, tweets, etc.


You should also start working on low level issues or help us with artwork, tweets, etc.

You should also start working on ~~low level~~ difficulty/low labelled issues or help us with artwork, tweets, etc.

meetmangukiya · 2016-10-08T17:15:49Z

Developers/Newcomers_Guide.rst

+ The first thing you should do is check other developers' pull requests to get the 
+ hang of things.
+ You should also start working on low level issues or help us with artwork, tweets, etc.
+


Same as requested above.

Notes haver been added to help necomers start fixing issues in the project. Fixes: coala#164

gitmate-bot · 2016-10-08T17:34:20Z

Thanks for your contribution!

Reviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.

I have rebased properly. Please see this for a tutorial.
I have gone through the commit guidelines and I've followed them:
- I have followed the guidelines for the commit shortlog.
- I have followed the guidelines for the commit body.
- I have included the issue URL.
- I have used the Fixes keyword if the commit fixes a real bug and the Closes keyword if it adds a feature/enhancement. See more here.
I have run all the tests and they all pass. That includes that all CI (below) is green - if GitMate issues appear you will have to amend your commits, pushing new commits on top is not sufficient!

As you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well!

prisas · 2016-10-08T17:34:49Z

Fixed the commit style to follow the guidelines.

sils · 2016-10-08T17:36:19Z

Developers/Newcomers_Guide.rst

+.. note::
+
+ The first thing you should do is check other developers' pull requests to get the 
+ hang of things.


I wouldn't recommend this as the first thing, first make a PR and then take a look at others, not only looking but also helping. Learning together with the others.

IMO though.

CC @Adrianzatreanu @adtac

sils · 2016-10-08T17:37:00Z

Developers/Newcomers_Guide.rst

+
+ The first thing you should do is check other developers' pull requests to get the 
+ hang of things.
+ You should also start working on difficulty/low labelled issues or help us with artwork, tweets, etc.


this sounds a bit vague, also I'd rather make like a strong recommendation to do this after they did the newcomer issue

Also the language could be a little more harsh. This doesn't mention anything about reviewers spending a lot of time on these things.

sils · 2016-10-08T17:37:13Z

Developers/Newcomers_Guide.rst

+
+ The first thing you should do is check other developers' pull requests to get the 
+ hang of things.
+ You should also start working on difficulty/low labelled issues or help us with artwork, tweets, etc.


sils · 2016-10-08T22:32:15Z

Btw. you seem to have two commits now, we only want one, riht? A rebase can help you. Here's the rebase instructions:

it looks like your PR is out of date and needs a rebase. This page may help you to get started on this. (Do not press the update branch button. It's evil.)

Add the original coala repository as a remote:

git remote add upstream https://github.com/coala/documentation.git

Then go to your branch and rebase it onto our master:

git checkout <yourbranch>
git fetch upstream
git rebase --interactive upstream/master

Here you can squash your commits!

Now push it up. You will need to do a force push because you change history here (do not do this on master branches :)):

git push --force

If you're just looking to fix an issue very quickly and not interested in contributing to coala long term, we can fix it up for you - just tell us :).

Ping us on our gitter channel if you need help!

gitmate-bot · 2016-10-16T03:10:26Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2016-10-16T03:10:27Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2016-10-23T01:50:20Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

gitmate-bot · 2016-10-23T01:50:20Z

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

aptrishu · 2016-10-23T14:26:45Z

Still working on this ? @paurisa
It has been a long time we haven't seen any update from you.

prisas · 2016-10-23T14:51:40Z

Isn't the issue already fixed? It says that it has already been closed so I thought it was fixed.
#164

aptrishu · 2016-10-23T15:01:03Z

Yes, It is fixed. You should close this PR. :)

prisas · 2016-10-23T15:02:14Z

Closing it then.

Nosferatul · 2016-10-23T15:03:53Z

@paurisa you should check https://github.com/coala/coala-bears/issues?q=is%3Aissue+is%3Aopen+label%3Adifficulty%2Fnewcomer

aptrishu · 2016-10-23T15:15:22Z

In case you haven't done any newcomer issue, then do one newcomer issue. Otherwise move to solve a difficulty : low issue. @paurisa

Fixed issue coala#164

ce147cc

gitmate-bot added process/pending review size/XS labels Oct 8, 2016

meetmangukiya requested changes Oct 8, 2016

View reviewed changes

Add recommendation notes for newcomers

490d1eb

Notes haver been added to help necomers start fixing issues in the project. Fixes: coala#164

gitmate-bot added size/S and removed size/XS labels Oct 8, 2016

sils reviewed Oct 8, 2016

View reviewed changes

sils added process/wip and removed process/pending review labels Oct 8, 2016

prisas closed this Oct 23, 2016

prisas reopened this Oct 23, 2016

prisas closed this Oct 23, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed issue #164 #165

Fixed issue #164 #165

prisas commented Oct 8, 2016

gitmate-bot commented Oct 8, 2016

meetmangukiya commented Oct 8, 2016

meetmangukiya Oct 8, 2016

meetmangukiya Oct 8, 2016

gitmate-bot commented Oct 8, 2016

prisas commented Oct 8, 2016

sils Oct 8, 2016

sils Oct 8, 2016

adtac Oct 8, 2016

sils Oct 8, 2016

sils commented Oct 8, 2016

gitmate-bot commented Oct 16, 2016

gitmate-bot commented Oct 16, 2016

gitmate-bot commented Oct 23, 2016

gitmate-bot commented Oct 23, 2016

aptrishu commented Oct 23, 2016 •

edited

Loading

prisas commented Oct 23, 2016

aptrishu commented Oct 23, 2016 •

edited

Loading

prisas commented Oct 23, 2016

Nosferatul commented Oct 23, 2016

aptrishu commented Oct 23, 2016

Fixed issue #164 #165

Fixed issue #164 #165

Conversation

prisas commented Oct 8, 2016

gitmate-bot commented Oct 8, 2016

meetmangukiya commented Oct 8, 2016

meetmangukiya Oct 8, 2016

Choose a reason for hiding this comment

meetmangukiya Oct 8, 2016

Choose a reason for hiding this comment

gitmate-bot commented Oct 8, 2016

prisas commented Oct 8, 2016

sils Oct 8, 2016

Choose a reason for hiding this comment

sils Oct 8, 2016

Choose a reason for hiding this comment

adtac Oct 8, 2016

Choose a reason for hiding this comment

sils Oct 8, 2016

Choose a reason for hiding this comment

sils commented Oct 8, 2016

gitmate-bot commented Oct 16, 2016

gitmate-bot commented Oct 16, 2016

gitmate-bot commented Oct 23, 2016

gitmate-bot commented Oct 23, 2016

aptrishu commented Oct 23, 2016 • edited Loading

prisas commented Oct 23, 2016

aptrishu commented Oct 23, 2016 • edited Loading

prisas commented Oct 23, 2016

Nosferatul commented Oct 23, 2016

aptrishu commented Oct 23, 2016

aptrishu commented Oct 23, 2016 •

edited

Loading

aptrishu commented Oct 23, 2016 •

edited

Loading