This repository has been archived by the owner on Mar 27, 2022. It is now read-only.
fix: atom-shell sync valid versions problem. (#241) #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fengmk2 请review一下 |
|
应该不是这个问题，你改的这一处只是获取 available 的 versions 的代码 实际上出问题的应该是 https://github.com/cnpm/mirrors/blob/master/sync/atom-shell.js#L34 代码里用到的这个查询 s3 bucket 资源的 api 现在需要鉴权。 所以后续代码就是执行出错了
所以问题应该是：列不出要下载的目录。 |
|
相关 issue: |
fengmk2
approved these changes
Oct 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
atom-shell
close #241
This change is