Refactor(2.3): improve delta_compactions #2046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igger normal compaction after delta compaction
roseboy-liu
approved these changes
Apr 3, 2024
|
It's some work to fix #1356. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required checklist
config,meta/configanddefault config)api changelabel.Which issue does this PR close?
Related #.
Rationale for this change
Some improvements of delta_compactions
Picker
Pick
compact_trigger_file_numlv0 files until there are no more lv0 files that contain the newest data numbered consecutively and, then pick the first lv0 file that overlaps with lv1_4.Job
Do not trigger normal compaction after delta compaction.
Others
Improve logs, with more debug information.
Are there any user-facing changes?