Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required checklist
config
,meta/config
anddefault config
)api change
label.Which issue does this PR close?
Related #.
Rationale for this change
Fix some bugs:
1. Compaction job failed to start;
CompactJobInner::enable_compaction
is initialized astrue
but the job starts only when itcompare_exchange(false, true) == Ok(false)
.cnosdb/tskv/src/compaction/job.rs
Lines 122 to 134 in 3112894
2. Errors in compact::chunk_merged_block();
There may be an error when chunking big blocks, this makes data lost.
3. Merge two tmp-fields in CompactIterator for better performance;
Merge
tmp_tsm_blk_meta_iters: Vec<BlockMetaIterator>
andtmp_tsm_blk_tsm_reader_idx: Vec<usize>
intotmp_tsm_blk_meta_iters: Vec<(usize, BlockMetaIterator)>
.4. Tombstone files not removed when removing TSM file
Tombstone files may be removed when dropping a
ColumnFile
.Are there any user-facing changes?