Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve: improve drop role message #1772

Merged
merged 1 commit into from
Nov 21, 2023
Merged

improve: improve drop role message #1772

merged 1 commit into from
Nov 21, 2023

Conversation

ZuoTiJia
Copy link
Contributor

Required checklist

  • Sample config files updated (config,meta/config and default config)
  • If there are user-facing changes, the documentation needs to be updated prior to approving the PR( Link )
  • If there are any breaking changes to public APIs, please add the api change label.
  • Signed CLA (if not already signed)

Related: #1761

roseboy-liu
roseboy-liu reviewed Nov 21, 2023
View reviewed changes
Copy link
Contributor

@roseboy-liu roseboy-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add test case

@ZuoTiJia ZuoTiJia changed the title improve: improve drop user message improve: improve drop role message Nov 21, 2023
@roseboy-liu roseboy-liu merged commit 837a5f3 into cnosdb:main Nov 21, 2023
7 checks passed
@ZuoTiJia ZuoTiJia deleted the drop-user-message branch November 21, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roseboy-liu roseboy-liu roseboy-liu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ZuoTiJia @roseboy-liu