Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: start the service through configuration #1685

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

Kree0
Copy link
Contributor

@Kree0 Kree0 commented Oct 31, 2023

Required checklist

  • Sample config files updated (config,meta/config and default config)
  • If there are user-facing changes, the documentation needs to be updated prior to approving the PR( Link )
  • If there are any breaking changes to public APIs, please add the api change label.
  • Signed CLA (if not already signed)

Which issue does this PR close?

Related #.

Rationale for this change

Are there any user-facing changes?

@zipper-meng
Copy link
Member

zipper-meng commented Nov 1, 2023

Write something to the PR conversations to describe what you've changed to the configurations, and the behavior of cnosdb or cnosdb-meta after we edit the config file as your forecasted in this PR, for example:

# Rationale for this change

## Make some configuration items optional

```toml
[cluster]
# http_listen_port = 8902
# grpc_listen_port = 8903
# flight_rpc_listen_port = 8904
# tcp_listen_port = 8905
# vector_listen_port = 8906

If comment the config grpc_listen_port or http_listen_port, then it panics when start, so cool.

The application panicked (crashed).
Message:  called `Option::unwrap()` on a `None` value
Location: /Users/magz/Rust/cnosdb/cnosdb/meta/src/model/meta_admin.rs:417

Backtrace omitted. Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.
fatal runtime error: failed to initiate panic, error 5
[1]    88324 abort      cargo run --bin cnosdb -- run -M singleton --config ./config/config_8902.toml

zipper-meng
zipper-meng previously approved these changes Nov 2, 2023
Copy link
Member

@zipper-meng zipper-meng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good

main/src/server.rs Outdated Show resolved Hide resolved
Copy link
Member

@zipper-meng zipper-meng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok.

@roseboy-liu roseboy-liu merged commit dd8367e into cnosdb:main Nov 6, 2023
6 checks passed
@Kree0 Kree0 deleted the config branch November 9, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants