Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Restore feature vnode checksum <group_id> #1621

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

zipper-meng
Copy link
Member

@zipper-meng zipper-meng commented Oct 17, 2023

Required checklist

  • Sample config files updated (config,meta/config and default config)
  • If there are user-facing changes, the documentation needs to be updated prior to approving the PR( Link )
  • If there are any breaking changes to public APIs, please add the api change label. - No
  • Signed CLA (if not already signed)

Which issue does this PR close?

#1641

Rationale for this change

  1. Restore commented code to get vnode checksum, and fit the new compaction iterator.
  2. Improve implements of std::fmt::Display of each hash tree structs, the prints now use JSON format.

Are there any user-facing changes?

Change

@zipper-meng zipper-meng force-pushed the feature/vnode_checksum branch 2 times, most recently from ee241ed to 179be40 Compare October 19, 2023 10:13
@roseboy-liu roseboy-liu merged commit ca46761 into cnosdb:main Nov 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants