fix(fs): normalize file manager API: distinguishing read,write,create #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3a0d735
to
2396a8d
Compare
roseboy-liu
approved these changes
Jun 19, 2023
2396a8d
to
e1061d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related #.
Rationale for this change
I thought methods in
FileManagerhas something wrong.open_filealso create the file if not exists.Errorinstanced too early.What changes are included in this PR?
open_file: Open a file to read.create_file: Open or create a file to read & write, overwrite if exists.open_create_file: Open or create a file to read & write, append if exists.remote_dir()toremove_dir_all().Are there any user-facing changes?