Make sure continuations are called only once in Relay code #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnixbtc
reviewed
Nov 2, 2022
There was a problem hiding this comment.
Awesome thanks for submitting this fix @ismyhc! 🎉
You're not stepping on anyone's toes here, quite the contrary. I'm happy that you find the project useful.
Code looks good, just a couple minor questions from my side. Let me know what you think!
cnixbtc
changed the title
cnixbtc
changed the title
cnixbtc
changed the title
|
@cnixbtc I also added Equatable to EventKind so that I could do comparisons on the enum as well as making the properties of EventFilter public so that the could be accessed. I need this when handing the EOSE event so I could figure out what type of subscription filter was finished. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! I believe I have fixed the issues I found where the sockets would crash after some time when the socket was disconnected. I hope Im not stepping on your toes. Just wanted to contribute what has fixed the issues for me so far :)
Basically, in the connect function where it was using the async wrapping function, continuation was being called multiple times. I removed that handled on disconnect a bit differently.
Also, I removed the async wrapping function from disconnect as the onDisconnect closure was already being handled in the connect function.