Fix volumizer bug #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rfdougherty can you double-check the logic here? |
Previous approach assumed that the first slice into the queue was the first slice from the acquisition. That is not always true. This approach computes the needed slices externally to the slices it actually gets. To do so it explicitly checks the exam/series/acq number of each incoming slice and determines if a new acquisition has started. This may cause problems if dicoms are written out of order with respect to acquisitions. Hopefully that will not happen.
|
OK I think this second approach is correct and addresses the problem you identified. Let me know what you think. |
|
Merging so it's easier to deal with on voxel2; this might not be perfect but it's definitely better than before :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the logic of the volumizer so that it explicity uses the
dicom instance numbers to order slices in each volume. This will make
robust to cases where the alphanumeric ordering of the dicom file names
does not correspond to the order of acquisition for each slice (#3).
Closes #3