annotations: correct go_package #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardjohn
force-pushed
the
annotations/correct-go-package
branch
from
cfd5b27
to
7980977
Compare
adisuissa
reviewed
Nov 22, 2023
udpa/annotations/migrate.proto
Outdated
| @@ -8,7 +8,7 @@ package udpa.annotations; | |||
|
|
|||
| import "google/protobuf/descriptor.proto"; | |||
|
|
|||
| option go_package = "github.com/cncf/xds/go/annotations"; | |||
| option go_package = "github.com/cncf/udpa/go/annotations"; | |||
There was a problem hiding this comment.
Shouldn't these be github.com/cncf/xds/go/udpa/annotations?
There was a problem hiding this comment.
Yes, good catch. updated
howardjohn
force-pushed
the
annotations/correct-go-package
branch
from
7980977
to
2a77a78
Compare
This is currently pointing at a non-existant package. Some proto tools just ignore this and make things work, but it should pont to the real go package for maximum compatibiltiy AFAIK. Signed-off-by: John Howard <[email protected]>
howardjohn
force-pushed
the
annotations/correct-go-package
branch
from
2a77a78
to
333aac8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently pointing at a non-existant package. Some proto tools just ignore this and make things work, but it should pont to the real go package for maximum compatibiltiy AFAIK.