Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 8 commits
- 51 files changed
- 4 contributors
Commits on Oct 11, 2023
-
cel: add a description to the AST (#61)
Signed-off-by: Kuat Yessenov <[email protected]>
Commits on Oct 16, 2023
-
Signed-off-by: Sergii Tkachenko <[email protected]>
Commits on Nov 9, 2023
-
bazel: fix "missing strict dependencies" build issue (#72)
Signed-off-by: Sergii Tkachenko <[email protected]>
Commits on Nov 16, 2023
-
bazel: Migrate py_proto_library to
@com_github_grpc_grpc(#74)py_proto_library provided by @com_google_protobuf//:protobuf.bzl has been deprecated for a while now: This is provided for backwards compatibility only. Bazel 5.3 will introduce support for py_proto_library, which should be used instead. https://github.com/protocolbuffers/protobuf/blob/32af7d211b85f71920acdfa9b796db008f8c2a45/protobuf.bzl#L642-L644 However, native py_proto_library has never been provided, see bazelbuild/bazel#3935. Instead @rules_python//python:proto.bzl is recommended. I attempted switching to this library, but it's not compatible with @com_google_googleapis's py_proto_library targets, see #69. I found a hacky workaround by using cc_proto_library to generate python targets, but downstream integration into Envoy failed (envoyproxy/envoy#30159). This PR migrates py_proto_library implementation to to @com_github_grpc_grpc. This implementation is used by @com_google_googleapis's, and, more importantly, uses bazel aspects. Which decouples cncf/xds and Envoy's dependencies from concrete upstream py_proto_library implementations. This resulted in a significant code improvement of bazel/api_build_system.bzl: No more custom @com_google_googleapis dependency mapping needed via py_proto_library rules override. No more hardcoded dependencies _xds_py_proto_library - proto dependency tree is determined from proto_library definitions via Basel aspects. No more EXTERNAL_PROTO_PY_BAZEL_DEP_MAP dependency map needed - for the same reason. Similar work in Envoy: envoyproxy/envoy#30834. Signed-off-by: Sergii Tkachenko <[email protected]>
Commits on Nov 17, 2023
-
Add canonical CEL support: dev.cel.expr (#75)
Signed-off-by: Sergii Tkachenko <[email protected]>
Commits on Nov 21, 2023
-
Revert "Add canonical CEL support: dev.cel.expr (#75)" (#79)
Signed-off-by: Sergii Tkachenko <[email protected]>
Commits on Nov 28, 2023
-
annotations: correct go_package (#80)
Signed-off-by: John Howard <[email protected]>
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff e9ce688...0fa0005